kleidiai: fix zero-size array declaration #17240
Merged
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ggml
chaxu01
reviewed
Nov 14, 2025
| }, | ||
| #endif | ||
| #endif | ||
| { /* Sentinel */ } |
Collaborator
There was a problem hiding this comment.
Using {0} as an explicit initializer.
| /* .op_type = */ GGML_TYPE_F32, | ||
| }, | ||
| #endif | ||
| { /* Sentinel */ } |
sudhiarm
force-pushed
the
fix/17187-zero-size-array
branch
from
373da48 to
dee8096
Compare
chaxu01
approved these changes
Nov 14, 2025
slaren
approved these changes
Nov 17, 2025
Member
|
Please check the CI failures. |
sudhiarm
force-pushed
the
fix/17187-zero-size-array
branch
from
dee8096 to
48800c5
Compare
Contributor
Author
|
I’ve reverted {0} back to {}. The {} performs full value-initialization. |
Contributor
Author
|
Hi @ggerganov, could you please take a look at this PR when you get a chance? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #17187.
Changes
{}sentinel element at the end of arrays to ensure they are never zero-sized.